Skip to content

added vietnamese#286

Open
chemchetchagio wants to merge 9 commits into
monogram-android:developfrom
chemchetchagio:develop
Open

added vietnamese#286
chemchetchagio wants to merge 9 commits into
monogram-android:developfrom
chemchetchagio:develop

Conversation

@chemchetchagio

Copy link
Copy Markdown

No description provided.

@gdlbo

gdlbo commented May 6, 2026

Copy link
Copy Markdown
Member

@chemchetchagio

Copy link
Copy Markdown
Author

sorry, letme translate that

@chemchetchagio

Copy link
Copy Markdown
Author

still wip, i will mention you when finish

still wip
still wip
still wip
still wip (soon)
@chemchetchagio

Copy link
Copy Markdown
Author

@gdlbo

gdlbo commented Jun 2, 2026

Copy link
Copy Markdown
Member

ERROR: /home/runner/work/monogram/monogram/presentation/src/main/res/values-vi/strings.xml:2345:3: Resource and asset merger: The element type "string" must be terminated by the matching end-tag "".
org.xml.sax.SAXParseException; lineNumber: 2345; columnNumber: 3; The element type "string" must be terminated by the matching end-tag "".
at java.xml/com.sun.org.apache.xerces.internal.util.ErrorHandlerWrapper.createSAXParseException(ErrorHandlerWrapper.java:204)
at java.xml/com.sun.org.apache.xerces.internal.util.ErrorHandlerWrapper.fatalError(ErrorHandlerWrapper.java:178)

fix issue

@chemchetchagio

Copy link
Copy Markdown
Author

sorry for the inconvenient, i will fix that

@chemchetchagio

Copy link
Copy Markdown
Author

fixed, you can try to compile it again

@gdlbo

gdlbo commented Jun 5, 2026

Copy link
Copy Markdown
Member

https://github.com/chemchetchagio/monogram/blob/develop/presentation%2Fsrc%2Fmain%2Fres%2Fvalues-vi%2Fstrings.xml#L1197-L1214

Bring back the original text for Konata

there's no need to come up with something new and etc

@chemchetchagio

Copy link
Copy Markdown
Author

fixed it

@gdlbo

gdlbo commented Jun 9, 2026

Copy link
Copy Markdown
Member

fixed it

The Vietnamese translation needs substantial revision before it is usable

A lot of strings do not read like normal product localization. Some use slang, jokes, exaggerated wording, or phrases that feel intentionally unserious. That tone needs to be removed completely. The app copy should be neutral, natural, and consistent with the rest of the interface

There are also strings where the meaning is wrong, distorted, or much stronger than the original. That is more serious than grammar issues, especially in authentication, moderation, reporting, privacy, permissions, and destructive actions. Those parts need careful retranslation from the source, not light editing

Please also review the file for spelling and grammar mistakes, inconsistent terminology, and any leftover English text. In addition, the Vietnamese resource set appears to be out of sync with the current base file, so the missing and outdated keys should be reconciled before merge

and rename strings.xml to string.xml

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants